hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13307) Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more throughput
Date Wed, 15 Apr 2015 15:51:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496421#comment-14496421
] 

stack commented on HBASE-13307:
-------------------------------

Here is commit comment:

{code}
This is for branch-1. Will do a master patch if this passes.

Make methods smaller so inlineable and compilable; saw complaint when -XX:+PrintInlining -XX:+PrintCompilation
enabled.
Maintain position in bytebuffer rather than ask BB to do it for us; this made BB#get go away
as hotspot in flamegraphs.
Use unsafe to parse shorts rather than have BB do it; faster in micro-benchmarks.
{code}

Here is https://reviews.apache.org/r/33226/

> Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more
throughput
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13307
>                 URL: https://issues.apache.org/jira/browse/HBASE-13307
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 13307.txt, 13307v2.branch-1.txt, 13307v3.branch-1.txt, 13307v4.branch-1.txt,
13307v5.branch-1.txt, 13307v6.branch-1.txt, cpu.png, gc.png, next.png, traces.8.svg, traces.9.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to be inlined
(looking at jvm compilation and inlining output flags -- see parent for list).  Changing method
size helped some. Let me commit the resultant patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message