hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13307) Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more throughput
Date Tue, 14 Apr 2015 06:20:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493653#comment-14493653
] 

Hadoop QA commented on HBASE-13307:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12725160/13307v4.branch-1.txt
  against branch-1 branch at commit 71536bdcc7d2d4b7a36a24ab9fa304cea4a8dda2.
  ATTACHMENT ID: 12725160

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail with
Hadoop version 2.4.1.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java:[119,35]
error: cannot find symbol
[ERROR]   symbol:   class ServerCell
[ERROR]   symbol:   class ServerCell
[ERROR]   symbol:   class ServerCell
[ERROR]   symbol:   class ServerCell
[ERROR]   symbol:   class ServerCell
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project hbase-client: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java:[119,35]
error: cannot find symbol
[ERROR] symbol:   class ServerCell
[ERROR] location: class ColumnRangeFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java:[219,36]
error: cannot find symbol
[ERROR] symbol:   class ServerCell
[ERROR] location: class ColumnRangeFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java:[219,9]
error: cannot find symbol
[ERROR] symbol:   class ServerCell
[ERROR] location: class ColumnRangeFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java:[108,35]
error: cannot find symbol
[ERROR] symbol:   class ServerCell
[ERROR] location: class ColumnPaginationFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java:[147,36]
error: cannot find symbol
[ERROR] symbol:   class ServerCell
[ERROR] location: class ColumnPaginationFilter
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java:[147,9]
error: cannot find symbol
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-client
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13693//console

This message is automatically generated.

> Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more
throughput
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13307
>                 URL: https://issues.apache.org/jira/browse/HBASE-13307
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 13307.txt, 13307v2.branch-1.txt, 13307v3.branch-1.txt, 13307v4.branch-1.txt,
traces.8.svg, traces.9.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to be inlined
(looking at jvm compilation and inlining output flags -- see parent for list).  Changing method
size helped some. Let me commit the resultant patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message