hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13078) IntegrationTestSendTraceRequests is a noop
Date Mon, 13 Apr 2015 18:25:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492789#comment-14492789

Nick Dimiduk commented on HBASE-13078:

My thinking is that we should have both: a medium or large test that verifies a single traced
invocation with everything enabled results in spans logged (and perhaps some validation thereof)
as well as a smoke test like this one that can be run to validate tracing is configured correctly
cluster-wide (ie, and spans are coming out of both hbase and hdfs). Maybe the latter is unreasonable?

Anyway, nice work [~elserj], +1.

> IntegrationTestSendTraceRequests is a noop
> ------------------------------------------
>                 Key: HBASE-13078
>                 URL: https://issues.apache.org/jira/browse/HBASE-13078
>             Project: HBase
>          Issue Type: Test
>          Components: integration tests
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
>         Attachments: HBASE-13078-0.98-removal.patch, HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch,
> While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that IntegrationTestSendTraceRequests
doesn't actually assert anything. This test should be converted to use a mini cluster, setup
a POJOSpanReceiver, and then verify the spans collected.

This message was sent by Atlassian JIRA

View raw message