hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13078) IntegrationTestSendTraceRequests is a noop
Date Sun, 12 Apr 2015 04:12:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491321#comment-14491321
] 

stack commented on HBASE-13078:
-------------------------------

bq. Are you suggesting that we just nuke this test completely in 0.98?

Yes. HTrace itself is a little wobbly. It is getting better in incubator but IMO, an IT for
the now-dead pre-incubator htrace is of a priority that is so low and for a service being
used rarely if at all, i'd suggest best just axe the test.

> IntegrationTestSendTraceRequests is a noop
> ------------------------------------------
>
>                 Key: HBASE-13078
>                 URL: https://issues.apache.org/jira/browse/HBASE-13078
>             Project: HBase
>          Issue Type: Test
>          Components: integration tests
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
>
>         Attachments: HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch, HBASE-13078.patch
>
>
> While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that IntegrationTestSendTraceRequests
doesn't actually assert anything. This test should be converted to use a mini cluster, setup
a POJOSpanReceiver, and then verify the spans collected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message