hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10800) Use CellComparator instead of KVComparator
Date Sat, 11 Apr 2015 12:07:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490985#comment-14490985
] 

Hadoop QA commented on HBASE-10800:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12724751/HBASE-10800_14.patch
  against master branch at commit e75c6201c69e57416525135a397a971ad4d1b902.
  ATTACHMENT ID: 12724751

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 251 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 16 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1934 checkstyle
errors (more than the master's current 1912 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    final int index = Bytes.searchDelimiterIndex(comparator, 0, comparator.length, ParseConstants.COLON);
+      final int rfamilyOffset, final int rfamilylength, final int rqualOffset, final int
rqualLength) {
+  // TODO : CLEANUP : in order to do this we may have to modify some code HRegion.next()
and will involve a
+   * @param coff the offset of the column hint if provided, if not offset of the currentCell's
qualifier
+   * @param clen the length of the column hint if provided, if not length of the currentCell's
qualifier
+    return Bytes.findCommonPrefix(left.getFamilyArray(), right.getFamilyArray(), left.getFamilyLength()
+    return matchingRow(a, b) && matchingFamily(a, b) && matchingQualifier(a,
b) && matchingTimestamp(a, b)
+  public static int searchDelimiterIndexInReverse(final byte[] b, final int offset, final
int length,
+    Bytes.equals(newKey.getRowArray(), newKey.getRowOffset(), newKey.getRowLength(), expectedArray,
0,
+    Bytes.equals(newKey.getRowArray(), newKey.getRowOffset(), newKey.getRowLength(), expectedArray,
0,

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestBlocksRead

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13670//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13670//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13670//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13670//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13670//console

This message is automatically generated.

> Use CellComparator instead of KVComparator
> ------------------------------------------
>
>                 Key: HBASE-10800
>                 URL: https://issues.apache.org/jira/browse/HBASE-10800
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-10800_1.patch, HBASE-10800_11.patch, HBASE-10800_12.patch,
HBASE-10800_13.patch, HBASE-10800_14.patch, HBASE-10800_2.patch, HBASE-10800_3.patch, HBASE-10800_4.patch,
HBASE-10800_4.patch, HBASE-10800_5.patch, HBASE-10800_6.patch, HBASE-10800_7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message