hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5980) Scanner responses from RS should include metrics on rows/KVs filtered
Date Wed, 29 Apr 2015 03:43:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518664#comment-14518664

Hadoop QA commented on HBASE-5980:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against branch-1 branch at commit 7348a05e9959c0891e1baebeef28c3be8feeb172.
  ATTACHMENT ID: 12728989

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 3796 checkstyle
errors (more than the master's current 3792 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +      " \003(\014\"\324\002\n\003Get\022\013\n\003row\030\001 \002(\014\022\027\n\006column\030\002
\003(" +
+      "unt\030\002 \001(\005\022\016\n\006exists\030\003 \001(\010\022\024\n\005stale\030\004
\001(\010" +
+      "\001 \002(\014\022\016\n\006family\030\002 \002(\014\022\021\n\tqualifier\030\003
\002(\014" +
+              new java.lang.String[] { "Region", "Scan", "ScannerId", "NumberOfRows", "CloseScanner",
"NextCallSeq", "ClientHandlesPartials", "ClientHandlesHeartbeats", "TrackScanMetrics", });
+              new java.lang.String[] { "CellsPerResult", "ScannerId", "MoreResults", "Ttl",
"Results", "Stale", "PartialFlagPerResult", "MoreResultsInRegion", "HeartbeatMessage", "ScanMetrics",
+        raise(ArgumentError, "Argument should be org.apache.hadoop.hbase.client.metrics.ScanMetrics")
+        # save row count to restore after printing metrics (metrics should not count towards
row count)

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s): 	at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService.testVisibilityLabelsInPutsThatDoesNotMatchAnyDefinedLabels(TestVisibilityLabelsWithCustomVisLabService.java:64)
	at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes.testDeleteColumnWithLatestTimeStampWhenNoVersionMatches(TestVisibilityLabelsWithDeletes.java:1115)
	at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL.testScanForUserWithFewerLabelAuthsThanLabelsInScanAuthorizations(TestVisibilityLabelsWithACL.java:119)
	at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsInPutsThatDoesNotMatchAnyDefinedLabels(TestVisibilityLabels.java:245)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13874//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13874//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13874//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13874//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13874//console

This message is automatically generated.

> Scanner responses from RS should include metrics on rows/KVs filtered
> ---------------------------------------------------------------------
>                 Key: HBASE-5980
>                 URL: https://issues.apache.org/jira/browse/HBASE-5980
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, metrics, regionserver
>    Affects Versions: 0.95.2
>            Reporter: Todd Lipcon
>            Assignee: Jonathan Lawlor
>            Priority: Minor
>         Attachments: HBASE-5980-branch-1.patch, HBASE-5980-v1.patch, HBASE-5980-v2.patch,
> Currently it's difficult to know, when issuing a filter, what percentage of rows were
skipped by that filter. We should expose some basic counters back to the client scanner object.
For example:
> - number of rows filtered by row key alone (filterRowKey())
> - number of times each filter response was returned by filterKeyValue() - corresponding
to Filter.ReturnCode
> What would be slickest is if this could actually return a tree of counters for cases
where FilterList or other combining filters are used. But a top-level is a good start.

This message was sent by Atlassian JIRA

View raw message