hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-5110) code enhancement - remove unnecessary if-checks in every loop in HLog class
Date Tue, 21 Apr 2015 00:50:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-5110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-5110:
----------------------------------
    Resolution: Not A Problem
        Status: Resolved  (was: Patch Available)

> code enhancement - remove unnecessary if-checks in every loop in HLog class
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-5110
>                 URL: https://issues.apache.org/jira/browse/HBASE-5110
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.90.1, 0.90.2, 0.90.4, 0.92.0
>            Reporter: Mikael Sitruk
>            Priority: Minor
>         Attachments: HBASE-5110_1.patch
>
>
> The HLog class (method findMemstoresWithEditsEqualOrOlderThan) has unnecessary if check
in a loop.
>  static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long oldestWALseqid,
>       final Map<byte [], Long> regionsToSeqids) {
>     //  This method is static so it can be unit tested the easier.
>     List<byte []> regions = null;
>     for (Map.Entry<byte [], Long> e: regionsToSeqids.entrySet()) {
>       if (e.getValue().longValue() <= oldestWALseqid) {
>         if (regions == null) regions = new ArrayList<byte []>();
>         regions.add(e.getKey());
>       }
>     }
>     return regions == null?
>       null: regions.toArray(new byte [][] {HConstants.EMPTY_BYTE_ARRAY});
>   }
> The following change is suggested
>   static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long oldestWALseqid,
>       final Map<byte [], Long> regionsToSeqids) {
>     //  This method is static so it can be unit tested the easier.
>     List<byte []> regions = new ArrayList<byte []>();
>     for (Map.Entry<byte [], Long> e: regionsToSeqids.entrySet()) {
>       if (e.getValue().longValue() <= oldestWALseqid) {
>         regions.add(e.getKey());
>       }
>     }
>     return regions.size() == 0?
>       null: regions.toArray(new byte [][] {HConstants.EMPTY_BYTE_ARRAY});
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message