Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A43A17C77 for ; Wed, 25 Mar 2015 13:25:57 +0000 (UTC) Received: (qmail 32499 invoked by uid 500); 25 Mar 2015 13:25:53 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 32459 invoked by uid 500); 25 Mar 2015 13:25:53 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 32447 invoked by uid 99); 25 Mar 2015 13:25:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2015 13:25:53 +0000 Date: Wed, 25 Mar 2015 13:25:53 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13331) Exceptions from DFS client can cause CatalogJanitor to delete referenced files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379856#comment-14379856 ] Matteo Bertozzi commented on HBASE-13331: ----------------------------------------- [~eclark] sorry I'm late here, why didn't you change the IOException in something like RegionDirNotFound or similar? instead of having the exists check also outside? {code} public static HRegionFileSystem openRegionFromFileSystem(final Configuration conf, final FileSystem fs, final Path tableDir, final HRegionInfo regionInfo, boolean readOnly) ... if (!fs.exists(regionDir)) { LOG.warn("Trying to open a region that do not exists on disk: " + regionDir); throw new IOException("The specified region do not exists on disk: " + regionDir); } {code} > Exceptions from DFS client can cause CatalogJanitor to delete referenced files > ------------------------------------------------------------------------------ > > Key: HBASE-13331 > URL: https://issues.apache.org/jira/browse/HBASE-13331 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 1.0.0, 0.98.12 > Reporter: Elliott Clark > Assignee: Elliott Clark > Priority: Blocker > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13 > > Attachments: HBASE-13331.patch, HBASE-13331.patch > > > CatalogJanitor#checkDaughterInFs assumes that there are no references whenever HRegionFileSystem.openRegionFromFileSystem throws IOException. Well Hadoop and HBase throw IOExceptions whenever someone looks in their general direction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)