Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 21 Mar 2015 17:31:38 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12783714.1426876253000.167670.1426959098468@Atlassian.JIRA>
In-Reply-To: <JIRA.12783714.1426876253000@Atlassian.JIRA>
References: <JIRA.12783714.1426876253000@Atlassian.JIRA>
 <JIRA.12783714.1426876253708@arcas>
Subject: [jira] [Commented] (HBASE-13305) Get(Get get) is not copying the
 row key
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372912#comment-14372912 ] 

Hadoop QA commented on HBASE-13305:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12706161/HBASE-13305.patch
  against master branch at commit a9b73b600e551749358a61bab27588e9074132d9.
  ATTACHMENT ID: 12706161

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13353//console

This message is automatically generated.

> Get(Get get) is not copying the row key
> ---------------------------------------
>
>                 Key: HBASE-13305
>                 URL: https://issues.apache.org/jira/browse/HBASE-13305
>             Project: HBase
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 1.0.0, 0.98.12
>            Reporter: Lars George
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13
>
>         Attachments: HBASE-13305.patch
>
>
> I tried this:
> {code}
>     Get get1 = new Get(Bytes.toBytes("row1"));
>     get1.addColumn(Bytes.toBytes("colfam1"), Bytes.toBytes("qual1"));
>     Get get2 = new Get(get1);
>     Result result = table.get(get2);
> {code}
> It fails (eventually) with: 
> {noformat}
> Mar 20, 2015 1:47:13 PM org.apache.hadoop.hbase.client.RpcRetryingCaller callWithRetries
> INFO: Call exception, tries=13, retries=35, started=170167 ms ago, cancelled=false, msg=row 'null' on table 'testtable' at null
> {noformat}
> And since you cannot assign a row key other than using the only other constructor {{Get(byte[] row)}} it means that above copy of get seems useless.
> Need to fix so that row is copied too.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)