Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C43E17BD8 for ; Mon, 23 Mar 2015 22:28:55 +0000 (UTC) Received: (qmail 70727 invoked by uid 500); 23 Mar 2015 22:28:55 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 70684 invoked by uid 500); 23 Mar 2015 22:28:55 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 70673 invoked by uid 99); 23 Mar 2015 22:28:55 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 22:28:55 +0000 Date: Mon, 23 Mar 2015 22:28:55 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13303) Fix size calculation of results on the region server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376784#comment-14376784 ] Andrew Purtell commented on HBASE-13303: ---------------------------------------- Agreed. bq. Only issue is we might not be honoring the actual max result size what user specified. Especially when the tags are returned back. Yes, this could be significantly more than expected. Also agreed we can handle this better as part of HBASE-13262 or a similar issue > Fix size calculation of results on the region server > ---------------------------------------------------- > > Key: HBASE-13303 > URL: https://issues.apache.org/jira/browse/HBASE-13303 > Project: HBase > Issue Type: Sub-task > Components: Client > Reporter: Lars Hofhansl > Assignee: Andrew Purtell > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12 > > Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303.patch, HBASE-13303.patch, HBASE-13303.patch, TestResultSizeEstimation.java > > > One of the problems in the parent is due to different size calculation between client and server when HFilev3 is used. > Since tags are _never_ shipped to the client in a scan, we can have special size function (or a flag on the current one) that does not include the tags and the tags meta information (the length is what causes the issue), so that client and server will always calculate the same size. > I'll make a patch within the hour, unless somebody beats me to it. > [~apurtell], FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)