Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 21 Mar 2015 00:12:39 +0000 (UTC)
From: "Srikanth Srungarapu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12783455.1426812835000.163929.1426896759246@Atlassian.JIRA>
In-Reply-To: <JIRA.12783455.1426812835000@Atlassian.JIRA>
References: <JIRA.12783455.1426812835000@Atlassian.JIRA>
 <JIRA.12783455.1426812835915@arcas>
Subject: [jira] [Updated] (HBASE-13294) Fix the critical ancient loopholes
 in security testing infrastructure.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Srikanth Srungarapu updated HBASE-13294:
----------------------------------------
    Attachment: HBASE-13294_v4.patch

Uploading the latest v4 patch from rb for QA bot to pick up.

> Fix the critical ancient loopholes in security testing infrastructure.
> ----------------------------------------------------------------------
>
>                 Key: HBASE-13294
>                 URL: https://issues.apache.org/jira/browse/HBASE-13294
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>         Attachments: HBASE-13294.patch, HBASE-13294_v2.patch, HBASE-13294_v3.patch, HBASE-13294_v3.patch, HBASE-13294_v4.patch
>
>
> Unfortunately, the "verifyDenied" method doesn't fail when action parameter returns null. The relevant code snippet
> {code}
> try {
>         Object obj = user.runAs(action);
>         if (requireException) {
>           fail("Expected exception was not thrown for user '" + user.getShortName() + "'");
>         }
>         if (obj != null && obj instanceof List<?>) {
>           List<?> results = (List<?>) obj;
>           if (results != null && !results.isEmpty()) {
>             fail("Unexpected results for user '" + user.getShortName() + "'");
>           }
>         }
>       }
> {code}
> As you can see, when obj is null, it returns silently. 
> Fixing this issue has uncovered another major bug. While constructing actions, we're using TEST_UTIL.getConnection(), which replaces the "doAs" user with the user who initiated the connection. I really am grateful to [~mbertozzi] without whom debugging this would have been a nightmare. 
> Now, fixing these two issues have uncovered more issues in our tests :). The main one is we're allowing the table owner to truncate table in code. But, in test, we're not allowing him. We should either remove the code that allows owner or document that the table owner can truncate table.
> The other minor issues include granting permissions to namespace, but checking whether user was able to access tables inside other namespace.  
> That's it, folks! 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)