Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E9D6177C8 for ; Wed, 18 Mar 2015 22:32:39 +0000 (UTC) Received: (qmail 57294 invoked by uid 500); 18 Mar 2015 22:32:39 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 57247 invoked by uid 500); 18 Mar 2015 22:32:39 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57235 invoked by uid 99); 18 Mar 2015 22:32:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 22:32:39 +0000 Date: Wed, 18 Mar 2015 22:32:39 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13274) Fix misplaced deprecation in Delete#addXYZ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13274?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D143= 68056#comment-14368056 ]=20 Nick Dimiduk commented on HBASE-13274: -------------------------------------- Oops. +1 > Fix misplaced deprecation in Delete#addXYZ > ------------------------------------------ > > Key: HBASE-13274 > URL: https://issues.apache.org/jira/browse/HBASE-13274 > Project: HBase > Issue Type: Bug > Components: API > Affects Versions: 1.0.0, 2.0.0 > Reporter: stack > Assignee: Mikhail Antonov > Attachments: HBASE-13274.patch > > > Found by [~larsgeorge] > {code} > All deleteXYZ() were deprecated in Delete in favour of the matching addXY= Z() (to mirror Put, Get, etc.) - _but_ for deleteFamilyVersion(). What is w= orse is, the @deprecated for it was added to the addFamilyVersion() replace= ment! Oh man. > * @deprecated Since hbase-1.0.0. Use {@link #addFamilyVersion(byte[], lon= g)}=E2=80=A8 */=E2=80=A8 @Deprecated=E2=80=A8 public Delete addFamilyVer= sion(final byte [] family, final long timestamp) { > The deprecated message is right, but on the wrong method > (areyoukiddingme) > Well, I presume it was done right, and will steer clear of deleteXYZ() in= favor of addXYZ() > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)