Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9E62173BD for ; Thu, 19 Mar 2015 10:49:38 +0000 (UTC) Received: (qmail 88240 invoked by uid 500); 19 Mar 2015 10:49:38 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 88188 invoked by uid 500); 19 Mar 2015 10:49:38 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88173 invoked by uid 99); 19 Mar 2015 10:49:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 10:49:38 +0000 Date: Thu, 19 Mar 2015 10:49:38 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13270) Setter for Result#getStats is #addResults; confusing! MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368848#comment-14368848 ] Matteo Bertozzi commented on HBASE-13270: ----------------------------------------- dumb question: why addStats() and not setStats()? we are not appending anything... maybe it is just grammar or it sounds better dunno :) > Setter for Result#getStats is #addResults; confusing! > ----------------------------------------------------- > > Key: HBASE-13270 > URL: https://issues.apache.org/jira/browse/HBASE-13270 > Project: HBase > Issue Type: Improvement > Reporter: stack > Labels: beginner > Attachments: HBASE-13270.patch > > > Below is our [~larsgeorge] on a finding he made reviewing our API: > "Result class having getStats() and addResults(Stats) makes little sense..." > "...the naming is just weird. You have a getStats() getter and an addResults(Stats) setter???" > "...Especially in the Result class and addResult() is plain misleading..." > This issue is about deprecating addResults and replacing it with addStats in its place. > The getStats/addResult is recent. It came in with: > {code} > commit a411227b0ebf78b4ee8ae7179e162b54734e77de > Author: Jesse Yates > Date: Tue Oct 28 16:14:16 2014 -0700 > HBASE-5162 Basic client pushback mechanism > ... > {code} > RegionLoadStats don't belong in Result if you ask me but better in the enveloping on invocations... but that is another issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)