Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F84417ACB for ; Wed, 18 Mar 2015 19:05:39 +0000 (UTC) Received: (qmail 50265 invoked by uid 500); 18 Mar 2015 19:05:39 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 50216 invoked by uid 500); 18 Mar 2015 19:05:39 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50204 invoked by uid 99); 18 Mar 2015 19:05:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 19:05:39 +0000 Date: Wed, 18 Mar 2015 19:05:39 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13269) Limit result array preallocation to avoid OOME with large scan caching values MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367681#comment-14367681 ] Lars Hofhansl commented on HBASE-13269: --------------------------------------- 100 is fine. In most cases we'll have the limit at "infinity" going forward (since limit is enforced by size). When a limit is specified it is likely going to be small. > Limit result array preallocation to avoid OOME with large scan caching values > ----------------------------------------------------------------------------- > > Key: HBASE-13269 > URL: https://issues.apache.org/jira/browse/HBASE-13269 > Project: HBase > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Fix For: 1.0.1, 0.98.12 > > Attachments: HBASE-13269-0.98.patch, HBASE-13269-1.0.patch > > > Scan#setCaching(Integer.MAX_VALUE) will likely terminate the regionserver with an OOME due to preallocation of the result array according to this parameter. We should limit the preallocation to some sane value. Definitely affects 0.98 (fix needed to HRegionServer) and 1.0.x (fix needed to RsRPCServices), not sure about later versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)