Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 17 Mar 2015 19:38:40 +0000 (UTC)
From: "Esteban Gutierrez (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12782634.1426613306000.121525.1426621120080@Atlassian.JIRA>
In-Reply-To: <JIRA.12782634.1426613306000@Atlassian.JIRA>
References: <JIRA.12782634.1426613306000@Atlassian.JIRA>
 <JIRA.12782634.1426613306729@arcas>
Subject: [jira] [Comment Edited] (HBASE-13266) test-patch.sh can return
 false positives for zombie tests from tests running on the same host
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365880#comment-14365880 ] 

Esteban Gutierrez edited comment on HBASE-13266 at 3/17/15 7:38 PM:
--------------------------------------------------------------------

Searching for hbase won't work since you can have multiple runs of test-patch.sh on the same host so that still trigger the false positives. What I was testing is to pass the patch id around here:

{code}
$MVN clean test -P runAllTests -DthisPatch=$defect -D${PROJECT_NAME}PatchProcess
{code}

and then carry this property all the way to surefire ${argLine} or ${hbase-surefire.argLine} and do a {{pgrep -f $defect}} instead of {{jps | grep surefirebooter | cut -d ' ' -f 1 | xargs -n 1 jstack}} maybe something like {{pgrep -f $defect | xargs -n 1 jstack}} but if you know a better way to get the id of forked maven test that might be better.


was (Author: esteban):
Searching for hbase won't work since you can have multiple runs of test-patch.sh on the same host so that still trigger the false positives. What I was testing is to pass the patch id around here:

{code}
$MVN clean test -P runAllTests -DthisPatch=$defect -D${PROJECT_NAME}PatchProcess
{code}

and then carry this property all the way to surefire ${argLine} or ${hbase-surefire.argLine} and do a {{pgrep -f $defect}} instead of {{jps | grep surefirebooter | cut -d ' ' -f 1 | xargs -n 1 jstack}} maybe something like {{pgrep -f $defect | cut -d ' ' -f 1 | xargs -n 1 jstack}} but if you know a better way to get the id of forked maven test that might be better.


> test-patch.sh can return false positives for zombie tests from tests running on the same host
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13266
>                 URL: https://issues.apache.org/jira/browse/HBASE-13266
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Esteban Gutierrez
>
> Just saw this here https://builds.apache.org/job/PreCommit-HBASE-Build/13271//consoleFull
> {code}
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:27 h
> [INFO] Finished at: 2015-03-16T23:58:30+00:00
> [INFO] Final Memory: 93M/844M
> [INFO] ------------------------------------------------------------------------
> Suspicious java process found - waiting 30s to see if there are just slow to stop
> There are 1 zombie tests, they should have been killed by surefire but survived
> ************ BEGIN zombies jstack extract
> 2015-03-16 23:59:03
> Full thread dump Java HotSpot(TM) Server VM (23.25-b01 mixed mode):
> "Attach Listener" daemon prio=10 tid=0xaa400800 nid=0x17cc waiting on condition [0x00000000]
>    java.lang.Thread.State: RUNNABLE
> "IPC Client (47) connection to 0.0.0.0/0.0.0.0:4324 from jenkins" daemon prio=10 tid=0xa8d03400 nid=0x1759 in Object.wait() [0xa9c7d000]
>    java.lang.Thread.State: TIMED_WAITING (on object monitor)
> 	at java.lang.Object.wait(Native Method)
> 	- waiting on <0xde1987c8> (a org.apache.hama.ipc.Client$Connection)
> 	at org.apache.hama.ipc.Client$Connection.waitForWork(Client.java:533)
> 	- locked <0xde1987c8> (a org.apache.hama.ipc.Client$Connection)
> 	at org.apache.hama.ipc.Client$Connection.run(Client.java:577)
> ...
>    java.lang.Thread.State: TIMED_WAITING (sleeping)
> 	at java.lang.Thread.sleep(Native Method)
> 	at org.apache.hama.bsp.TestBSPTaskFaults.tearDown(TestBSPTaskFaults.java:618)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> {code}
> Which is getting a jstack from a test from Hama.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)