Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 090C317AE1 for ; Tue, 17 Mar 2015 19:16:39 +0000 (UTC) Received: (qmail 66497 invoked by uid 500); 17 Mar 2015 19:16:38 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 66454 invoked by uid 500); 17 Mar 2015 19:16:38 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 66300 invoked by uid 99); 17 Mar 2015 19:16:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 19:16:38 +0000 Date: Tue, 17 Mar 2015 19:16:38 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13253) LoadIncrementalHFiles unify hfiles discovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365835#comment-14365835 ] stack commented on HBASE-13253: ------------------------------- As per [~srikanth235], LGTM [~mbertozzi] Nice cleanup. > LoadIncrementalHFiles unify hfiles discovery > -------------------------------------------- > > Key: HBASE-13253 > URL: https://issues.apache.org/jira/browse/HBASE-13253 > Project: HBase > Issue Type: Bug > Components: Client, mapreduce > Affects Versions: 1.0.0, 2.0.0, 1.1.0, 0.98.11 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Attachments: HBASE-13253-v0.patch, HBASE-13253-v1.patch > > > We have two copy-pasted code-path in createTable() and discoverLoadQueue(). They do does the same exact loop on the fs with the same validation logic. we should unify them, to avoid having them out of sync -- This message was sent by Atlassian JIRA (v6.3.4#6332)