Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 870D61737B for ; Tue, 3 Mar 2015 22:30:21 +0000 (UTC) Received: (qmail 78179 invoked by uid 500); 3 Mar 2015 22:30:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 78130 invoked by uid 500); 3 Mar 2015 22:30:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78118 invoked by uid 99); 3 Mar 2015 22:30:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Mar 2015 22:30:05 +0000 Date: Tue, 3 Mar 2015 22:30:05 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13145) TestNamespaceAuditor.testRegionMerge is flaky MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345883#comment-14345883 ] Hudson commented on HBASE-13145: -------------------------------- FAILURE: Integrated in HBase-TRUNK #6202 (See [https://builds.apache.org/job/HBase-TRUNK/6202/]) HBASE-13145 TestNamespaceAuditor.testRegionMerge is flaky (stack: rev 3897ab05a4630d6351853e17d82944fddd64e664) * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > TestNamespaceAuditor.testRegionMerge is flaky > --------------------------------------------- > > Key: HBASE-13145 > URL: https://issues.apache.org/jira/browse/HBASE-13145 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 2.0.0, 1.1.0 > Reporter: zhangduo > Assignee: zhangduo > Fix For: 2.0.0, 1.1.0 > > Attachments: HBASE-13145.patch, HBASE-13145.patch > > > Dig into the log > https://builds.apache.org/job/HBase-TRUNK/6197/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.namespace.TestNamespaceAuditor-output.txt > Seems a split operation which we expect to success is started before we finishing a merge and cause an infinite sleep loop. > I guess the problem is here > {code:title=TestNamespaceAuditor.java} > // merge the two regions > admin.mergeRegions(hris.get(0).getEncodedNameAsBytes(), > hris.get(1).getEncodedNameAsBytes(), false); > > while (admin.getTableRegions(tableTwo).size() == initialRegions) { > Thread.sleep(100); > } > {code} > I guess that during a merge, we can get more region count than before because we first online the new region and then offline the two old regions. > So change it to admin.getTableRegions(tableTwo).size() != initialRegions - 1 may work. > And we can modify the while loop to use Waiter.waitFor which can provide more useful information when test failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)