hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13353) [Shell] get_counter is asking for too many parameters
Date Sat, 28 Mar 2015 08:41:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385194#comment-14385194
] 

Lars George commented on HBASE-13353:
-------------------------------------

Yes JM, I did find your JIRA just then. I cannot believe this is broken for a year now. Man!
Let's fix this over in HBASE-10728, and I will commit it. OK?

> [Shell] get_counter is asking for too many parameters
> -----------------------------------------------------
>
>                 Key: HBASE-13353
>                 URL: https://issues.apache.org/jira/browse/HBASE-13353
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.0.0
>            Reporter: Lars George
>              Labels: noob
>
> Trying:
> {code}
> hbase(main):036:0> get_counter 'counters', '20150101', 'daily:hits'
> {code}
> and getting 
> {code}
> ERROR: wrong number of arguments (3 for 4)
> ...
>   hbase> get_counter 'ns1:t1', 'r1', 'c1'
>   hbase> get_counter 't1', 'r1', 'c1'
> {code}
> It is asking for another, undocumented parameter. The issue is that there is a "can be
nil" markup missing in get_counter.rb:
> {code}
> 39 def command(table, row, column, value)
> 40    get_counter(table(table), row, column, value)
> 41 end
> {code} 
> The first line should be:
> {code}
> 39 def command(table, row, column, value = nil)
> {code}
> Easy fix, but makes me wonder why this is not caught anywhere or reported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message