hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13340) Include LimitedPrivate interfaces in the API compatibility report
Date Thu, 26 Mar 2015 22:56:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382882#comment-14382882
] 

Dima Spivak commented on HBASE-13340:
-------------------------------------

I approve. Should just be able to [this line|https://github.com/apache/hbase/blob/master/dev-support/check_compatibility.sh#L247]
and update [this one|https://github.com/apache/hbase/blob/master/dev-support/check_compatibility.sh#L250]
to properly do the variable substitution for the array.

> Include LimitedPrivate interfaces in the API compatibility report
> -----------------------------------------------------------------
>
>                 Key: HBASE-13340
>                 URL: https://issues.apache.org/jira/browse/HBASE-13340
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> The API compatibility checker script added in HBASE-12808 passes a file containing annotations
to the JavaACC tool. When JavaACC is invoked with that option it will filter out all interfaces
that do not have that annotation. Currently only Public interfaces are checked. We should
add LimitedPrivate to the annotation list, otherwise we will miss changes that impact coprocessors
and other users of those interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message