hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13332) Fix the usage of doAs/runAs in Visibility Controller tests.
Date Wed, 25 Mar 2015 23:53:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381057#comment-14381057

Andrew Purtell commented on HBASE-13332:

bq. But, if you are okay, I can convert all of them to try with resources format.
I like your related patch to AccessController that gets a Connection and then a Table from
the connection in a try-with-resources. Looks clean. Would be good too here if you're up for

bq. I can create a follow-on jira, for cleaning the leaks and integrate try-with-resources
or I can add them to this patch.
Might as well do it here. The try-with-resources changes would all go in actions set up fordoAs/runAs,
so that's germane. Fixing unclosed HTables is fair game whenever we find that in tests, but
if you want to make a separate issue and patch for that, that's fine. 

> Fix the usage of doAs/runAs in Visibility Controller tests.
> -----------------------------------------------------------
>                 Key: HBASE-13332
>                 URL: https://issues.apache.org/jira/browse/HBASE-13332
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>             Fix For: 2.0.0, 1.0.1, 1.1.0
>         Attachments: HBASE-13332.patch, HBASE-13332.patch
> The "doAs" bug is also affecting VC related tests too. 

This message was sent by Atlassian JIRA

View raw message