hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13331) Exceptions from DFS client can cause CatalogJanitor to delete referenced files
Date Wed, 25 Mar 2015 13:25:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379856#comment-14379856
] 

Matteo Bertozzi commented on HBASE-13331:
-----------------------------------------

[~eclark] sorry I'm late here, why didn't you change the IOException in something like RegionDirNotFound
or similar? instead of having the exists check also outside?
{code}
public static HRegionFileSystem openRegionFromFileSystem(final Configuration conf,
      final FileSystem fs, final Path tableDir, final HRegionInfo regionInfo, boolean readOnly)
    ...
    if (!fs.exists(regionDir)) {
      LOG.warn("Trying to open a region that do not exists on disk: " + regionDir);
      throw new IOException("The specified region do not exists on disk: " + regionDir);
    }
{code}

> Exceptions from DFS client can cause CatalogJanitor to delete referenced files
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-13331
>                 URL: https://issues.apache.org/jira/browse/HBASE-13331
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.0.0, 0.98.12
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Blocker
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13
>
>         Attachments: HBASE-13331.patch, HBASE-13331.patch
>
>
> CatalogJanitor#checkDaughterInFs assumes that there are no references whenever HRegionFileSystem.openRegionFromFileSystem
throws IOException. Well Hadoop and HBase throw IOExceptions whenever someone looks in their
general direction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message