hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13322) Replace explicit HBaseAdmin creation with connection#getAdmin()
Date Wed, 25 Mar 2015 16:12:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380137#comment-14380137
] 

Nick Dimiduk commented on HBASE-13322:
--------------------------------------

Patch looks good structurally. I'm a little surprised there's so many places where a connection
instance isn't already available. Despite the easy syntax of try-with-resources, it seems
to be we should try really hard to not create extra connections unnecessarily. Tests usually
have a member variable, accessible from {{HBaseTestingUtility}}, Master and Region Servers
should have them available in some global place for management utilities and webUI's. Can
we at least change the prod code to make an effort at connection reuse? I'm looking at {{RegionSizeCalculator}}
and {{tablesDetailed.jsp}}.

> Replace explicit HBaseAdmin creation with connection#getAdmin()
> ---------------------------------------------------------------
>
>                 Key: HBASE-13322
>                 URL: https://issues.apache.org/jira/browse/HBASE-13322
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>            Priority: Minor
>         Attachments: HBASE-13322.patch, HBASE-13322.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message