hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13307) Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more throughput
Date Sat, 21 Mar 2015 17:18:38 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-13307:
--------------------------
    Attachment: traces.8.svg

I tried 512 too and started to get ' total inlining greater than DesiredMethodLimit'. It does
not run faster. Attached flame graph for my run has same profile as default for MaxInlineSize
(same percentage CPU for _next). Would be interested to see if you see any benefit in your
rig w/ patch attached here.

> Making methods under ScannerV2#next smaller allows them to be inlined gaining us 7% more
throughput
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13307
>                 URL: https://issues.apache.org/jira/browse/HBASE-13307
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 13307.txt, traces.8.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to be inlined
(looking at jvm compilation and inlining output flags -- see parent for list).  Changing method
size helped some. Let me commit the resultant patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message