hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Lawlor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13303) Fix size calculation of results on the region server
Date Thu, 26 Mar 2015 21:44:56 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382742#comment-14382742
] 

Jonathan Lawlor commented on HBASE-13303:
-----------------------------------------

bq. Not sure about branch-1.0 but there's no release on deck there yet

The improper calculations I called out above would only be relevant where HBASE-11544 is (branch-1+),
so branch-1.0 wouldn't need to change.

bq. So in summary if the addendum to HBASE-11544 fixes this issue properly in branch-1+, let's
simply revert HBASE-13303.

I believe the only fix that would allow this to be reverted would be the fix from the parent
issue, HBASE-13262 (and even with that fix I'm not sure we could revert the hack because of
the possibility that the server could be talking to an older client that doesn't recognize
the new flag being added). The addendum to HBASE-11544 wouldn't properly fix the issue in
branch-1+ but rather would adapt its size calculation to use the hack.

> Fix size calculation of results on the region server
> ----------------------------------------------------
>
>                 Key: HBASE-13303
>                 URL: https://issues.apache.org/jira/browse/HBASE-13303
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>
>         Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, HBASE-13303-0.98.patch,
HBASE-13303.patch, HBASE-13303.patch, HBASE-13303.patch, TestResultSizeEstimation.java
>
>
> One of the problems in the parent is due to different size calculation between client
and server when HFilev3 is used.
> Since tags are _never_ shipped to the client in a scan, we can have special size function
(or a flag on the current one) that does not include the tags and the tags meta information
(the length is what causes the issue), so that client and server will always calculate the
same size.
> I'll make a patch within the hour, unless somebody beats me to it.
> [~apurtell], FYI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message