hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-13303) Fix size calculation of results on the region server
Date Fri, 20 Mar 2015 18:21:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371775#comment-14371775
] 

Andrew Purtell edited comment on HBASE-13303 at 3/20/15 6:21 PM:
-----------------------------------------------------------------

Is this what you had in mind [~lhofhansl] ? 

This code makes me want to cry, though, backwards compatible mis-estimations. 

The instanceof check in the static helper should be fine. In interpreter or C1, Hotspot will
build a type profile for every cast and instanceof and optimistically specialize in C2 if
it only sees one type at the receiver (with a trap to deopt if wrong).


was (Author: apurtell):
Is this what you had it mind [~lhofhansl] ? 
This code makes me want to cry, though.

> Fix size calculation of results on the region server
> ----------------------------------------------------
>
>                 Key: HBASE-13303
>                 URL: https://issues.apache.org/jira/browse/HBASE-13303
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Lars Hofhansl
>             Fix For: 2.0.0, 1.1.0, 0.98.13
>
>         Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch
>
>
> One of the problems in the parent is due to different size calculation between client
and server when HFilev3 is used.
> Since tags are _never_ shipped to the client in a scan, we can have special size function
(or a flag on the current one) that does not include the tags and the tags meta information
(the length is what causes the issue), so that client and server will always calculate the
same size.
> I'll make a patch within the hour, unless somebody beats me to it.
> [~apurtell], FYI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message