hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13274) Fix misplaced deprecation in Delete#addXYZ
Date Fri, 20 Mar 2015 18:58:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371869#comment-14371869
] 

Hudson commented on HBASE-13274:
--------------------------------

FAILURE: Integrated in HBase-1.1 #307 (See [https://builds.apache.org/job/HBase-1.1/307/])
HBASE-13274 Fix misplaced deprecation in Delete#addXYZ (Mikhail Antonov) (stack: rev b83e3ac7707dcaa4932561c5c1bf78e3d0dc5d3d)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java


> Fix misplaced deprecation in Delete#addXYZ
> ------------------------------------------
>
>                 Key: HBASE-13274
>                 URL: https://issues.apache.org/jira/browse/HBASE-13274
>             Project: HBase
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: stack
>            Assignee: Mikhail Antonov
>             Fix For: 2.0.0, 1.0.1, 1.1.0
>
>         Attachments: HBASE-13274.patch
>
>
> Found by [~larsgeorge]
> {code}
> All deleteXYZ() were deprecated in Delete in favour of the matching addXYZ() (to mirror
Put, Get, etc.) - _but_ for deleteFamilyVersion(). What is worse is, the @deprecated for it
was added to the addFamilyVersion() replacement! Oh man.
> * @deprecated Since hbase-1.0.0. Use {@link #addFamilyVersion(byte[], long)}
  */

 @Deprecated
  public Delete addFamilyVersion(final byte [] family, final long timestamp)
{
> The deprecated message is right, but on the wrong method
> (areyoukiddingme)
> Well, I presume it was done right, and will steer clear of deleteXYZ() in favor of addXYZ()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message