hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13257) Show coverage report on jenkins
Date Wed, 18 Mar 2015 05:20:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366659#comment-14366659

stack commented on HBASE-13257:

Precommit would be the ideal place. Interested parties could check their patch to see how
its coverage is.

That it slows our already too-long precommit by 1/4 is a high price to pay for a report that
few will likely consult.

On other hand this fancy view on findbugs and checkstyle errors is much nicer than the clicking
around we currently have to do with our current findbugs and checkstyle runs. It lists counts
in the main build page too. Our current findbugs and checkstyle checks look to see if the
patch adds new findbugs or checkstyle warnings. Could we do that in this view?  Or have our
scripts read from here the count found and compare to a save-doff number? Could be in a follow-on.

If we disabled the findbugs and checkstyle runs in our run-test.sh script, we'd get some of
the 1/4 back? (Could do the findbugs and checkstyle could be in a follow on too).

Looks like I've just argued myself into enabling this on precommit.

> Show coverage report on jenkins
> -------------------------------
>                 Key: HBASE-13257
>                 URL: https://issues.apache.org/jira/browse/HBASE-13257
>             Project: HBase
>          Issue Type: Task
>            Reporter: zhangduo
>            Assignee: zhangduo
>            Priority: Minor
> Think of showing jacoco coverage report on https://builds.apache.org .
> And there is an advantage of showing it on jenkins that the jenkins jacoco plugin can
handle cross module coverage.
> Can not do it locally since https://github.com/jacoco/jacoco/pull/97 is still pending.

This message was sent by Atlassian JIRA

View raw message