hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13252) Get rid of managed connections and connection caching
Date Sat, 28 Mar 2015 03:57:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385101#comment-14385101
] 

stack commented on HBASE-13252:
-------------------------------

Nice radical cleanup [~mantonov]

If you are going to make a new patch, get rid of internalClose (just call close)... but no
biggie... I can do on commit if you agree.

bq. One question where I'd appreciate comment - ServerResourceCheckerJUnitListener seems to
be not needed now, is that right? We don't trace leaking connection anymore, as we don't track
number of cached connections (as they are not cached at all).

That is how I read it. It was checking that when we did the internal connection management
delete of stale connections, that we'd clean up zk so no leaks. Your removal seems right to
me.

+1 from me on patch.

Waiting on blessing of [~ndimiduk]


> Get rid of managed connections and connection caching
> -----------------------------------------------------
>
>                 Key: HBASE-13252
>                 URL: https://issues.apache.org/jira/browse/HBASE-13252
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 2.0.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>         Attachments: HBASE-13252-v0.patch, HBASE-13252-v1.patch, HBASE-13252-v1.patch,
HBASE-13252-v2.patch, HBASE-13252-v2.patch, HBASE-13252-v3.patch, HBASE-13252-v4.patch
>
>
> (Need to):
>  - Remove CONNECTION_INSTANCES from ConnectionManager
>  - Remove HConnectionKey
>  - Remove 'managed' property from ClusterConnection, HCI and places where it's used now
>  - AFAIS this property isn't visible to client (ClusterConnection is private interface),
so technically this would not even be backward-incompatible change, and no release note needed?
>  - In fact, ConnectionManager can be removed, too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message