hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13248) Make HConnectionImplementation top-level class.
Date Sat, 21 Mar 2015 06:03:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372539#comment-14372539
] 

Hadoop QA commented on HBASE-13248:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12706120/HBASE-13248-v2.patch
  against master branch at commit 8dfed5dc88f1c8008345b22e99224cb945fd0941.
  ATTACHMENT ID: 12706120

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 39 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1928 checkstyle
errors (more than the master's current 1918 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    String key = getStubKey(ClientProtos.ClientService.BlockingInterface.class.getName(),
sn.getHostname(),
+      public MasterProtos.AddColumnResponse addColumn(RpcController controller, MasterProtos.AddColumnRequest
request)
+          RpcController controller, MasterProtos.CreateNamespaceRequest request) throws ServiceException
{
+          RpcController controller, MasterProtos.DeleteNamespaceRequest request) throws ServiceException
{
+      public MasterProtos.GetNamespaceDescriptorResponse getNamespaceDescriptor(RpcController
controller,
+      public MasterProtos.ListNamespaceDescriptorsResponse listNamespaceDescriptors(RpcController
controller,
+   * @deprecated since 0.96 - Use {@link org.apache.hadoop.hbase.client.HTableInterface#batch}
instead
+   * @deprecated since 0.96 - Use {@link org.apache.hadoop.hbase.client.HTable#processBatchCallback}
instead
+   * below will ensure that this {@link org.apache.hadoop.hbase.client.HConnection} instance
is cleaned up.
+   * @deprecated Use {@link org.apache.hadoop.hbase.client.Admin#getTableDescriptorsByTableName(java.util.List)}
instead

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13348//console

This message is automatically generated.

> Make HConnectionImplementation top-level class.
> -----------------------------------------------
>
>                 Key: HBASE-13248
>                 URL: https://issues.apache.org/jira/browse/HBASE-13248
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 2.0.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>         Attachments: HBASE-13248-v2.patch, HBASE-13248-v2.patch, HBASE-13248.patch
>
>
> To separate concerns inside ConnectionManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message