hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13208) Patch build should match the patch filename and not the whole relative URL in findBranchNameFromPatchName
Date Wed, 11 Mar 2015 19:02:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357404#comment-14357404
] 

Sean Busbey commented on HBASE-13208:
-------------------------------------

my bad, looks like I can stop checking on matching the beginning as well. the lack of a start/end
anchor should have been an indicator.

+1 will push shortly unless someone wants a change.

> Patch build should match the patch filename and not the whole relative URL in findBranchNameFromPatchName
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13208
>                 URL: https://issues.apache.org/jira/browse/HBASE-13208
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Trivial
>         Attachments: 0001-HBASE-13208-Patch-build-should-match-the-patch-filen.patch
>
>
> In HBASE-1319 we saw that the patch got applied to the wrong branch, the problem is findBranchNameFromPatchName
matching a regex that contains wildcard symbols against the whole URL, in this case the regex
is 0.94 and the relativePatchURL is /jira/secure/attachment/12703942/HBASE-13193-v4.patch
where 0394 is a match.
> Thanks to  [~jonathan.lawlor] for reporting this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message