hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-13205) [branch-1] Backport HBASE-11598 Add simple rpc throttling
Date Sat, 14 Mar 2015 01:06:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361440#comment-14361440
] 

Andrew Purtell edited comment on HBASE-13205 at 3/14/15 1:05 AM:
-----------------------------------------------------------------

You have a need for this in 0.98 [~ashish singhi]? 

I think it would be nice to have an admission control capability in 0.98 as long as we can
be compatible in the following ways:
- Rolling upgrades are possible, with configuration updates for new features deferred until
the fleet is all at the same version
- Old clients can talk to new servers
- Old servers can talk to new clients, excepting where new APIs are not available on the server
side, and this is handled gracefully

I made a quick pass over the branch-1 patch:
- In 0.98, Connection and ConnectionManager are HConnection and HConnectionManager, respectively.
Both are marked Public/Evolving and not meant for direct client extension anyway. We discussed
this earlier when backporting client load backoff.
- Protobuf changes are wire compatible
- There are new methods added to MasterObserver, for support for intercepting new admin APIs
for quotas. The abstract base classes we have to assist implementors when this API evolves
are updated with default implementations.
- Adding new methods to interfaces like HBaseAdmin is binary compatible with earlier compiled
code
- Shell changes are additive
- Other affected classes and interfaces are marked private.

I don't see a blocking issue.


was (Author: apurtell):
You have a need for this in 0.98 [~ashish singhi]? 

I think it would be nice to have an admission control capability in 0.98 as long as we can
be compatible in the following ways:
- Rolling upgrades are possible, with configuration updates for new features deferred until
the fleet is all at the same version
- Old clients can talk to new servers
- Old servers can talk to new clients, excepting where new APIs are not available on the server
side, and this is handled gracefully

I made a quick pass over the branch-1 pass:
- In 0.98, Connection and ConnectionManager are HConnection and HConnectionManager, respectively.
Both are marked Public/Evolving and not meant for direct client extension anyway. We discussed
this earlier when backporting client load backoff.
- Protobuf changes are wire compatible
- There are new methods added to MasterObserver, for support for intercepting new admin APIs
for quotas. The abstract base classes we have to assist implementors when this API evolves
are updated with default implementations.
- Adding new methods to interfaces like HBaseAdmin is binary compatible with earlier compiled
code
- Shell changes are additive
- Other affected classes and interfaces are marked private.

I don't see a blocking issue.

> [branch-1] Backport HBASE-11598 Add simple rpc throttling
> ---------------------------------------------------------
>
>                 Key: HBASE-13205
>                 URL: https://issues.apache.org/jira/browse/HBASE-13205
>             Project: HBase
>          Issue Type: Task
>          Components: security
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>              Labels: multitenancy, quota
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13205-branch-1.patch, HBASE-13205-v1-branch-1.patch, HBASE-13205-v2-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message