hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13199) Some small improvements on canary tool
Date Thu, 19 Mar 2015 12:14:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368974#comment-14368974
] 

Matteo Bertozzi commented on HBASE-13199:
-----------------------------------------

looks like the commit introduced a new findbug error
{noformat}
Nullcheck of table at line 152 of value previously dereferenced in org.apache.hadoop.hbase.tool.Canary$RegionTask.call()
Bug type RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE (click for details) 
In class org.apache.hadoop.hbase.tool.Canary$RegionTask
In method org.apache.hadoop.hbase.tool.Canary$RegionTask.call()
Value loaded from table
Return value of org.apache.hadoop.hbase.client.Connection.getTable(TableName)
At Canary.java:[line 152]
Redundant null check at Canary.java:[line 207]
{noformat}

> Some small improvements on canary tool
> --------------------------------------
>
>                 Key: HBASE-13199
>                 URL: https://issues.apache.org/jira/browse/HBASE-13199
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13199-v1.diff, HBASE-13199-v2.diff, HBASE-13199-v3.diff, HBASE-13199-v4.diff
>
>
> Improvements
> - Make the sniff of region and regionserver parallel to support large cluster with 10000+
region and 500+ regionservers using thread pool.
> - Set cacheblock to false in get and scan to avoid influence to block cache.
> - Add FirstKeyOnlyFilter to get and scan to avoid read and translate too many data from
HBase. There may be many column under a column family in a flat-wide table.
>  - Select the region randomly when sniffing a regionserver.
>  - Make the sink class of canary configurable
> [~stack]
> Suggestions are welcomed. Thanks~
> Another question is that why to check each column family with separate requests when
sniffing a region? Can we just check a  column family of a region?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message