hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13193) RegionScannerImpl filters should not be reset if a partial Result is returned
Date Wed, 11 Mar 2015 17:02:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357200#comment-14357200
] 

Hadoop QA commented on HBASE-13193:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12703942/HBASE-13193-v4.patch
  against 0.94 branch at commit e66dca6cd1fd91bfa65a7cd4c68acb7a7f6a6c4e.
  ATTACHMENT ID: 12703942

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13191//console

This message is automatically generated.

> RegionScannerImpl filters should not be reset if a partial Result is returned
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-13193
>                 URL: https://issues.apache.org/jira/browse/HBASE-13193
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jonathan Lawlor
>            Assignee: Jonathan Lawlor
>         Attachments: HBASE-13193-v1.patch, HBASE-13193-v2.patch, HBASE-13193-v3.patch,
HBASE-13193-v4.patch
>
>
> In RegionScannerImpl the filters get reset during calls to nextRaw:
> {code}
> public NextState nextRaw(List<Cell> outResults, int batchLimit, long remainingResultSize)
>         throws IOException {
>   ...
>   resetFilters();
>   if (isFilterDoneInternal()) {
>   ...
> }
> {code}
> This creates a problem when returning partial Results because filters should only be
reset in between rows (i.e. after all of the cells for a particular row have been returned).
If a partial Result is returned, there are still cells in the row that have not been evaluated
yet and we should avoid resetting the filter since it will wipe away all state information
for that filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message