hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13193) RegionScannerImpl filters should not be reset if a partial Result is returned
Date Tue, 10 Mar 2015 21:51:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355796#comment-14355796
] 

Ted Yu commented on HBASE-13193:
--------------------------------

{code}
617     if (partialResultsRow != null && !Bytes.equals(row, partialResultsRow)) {
618       throw new IOException("Partial result row does not match. All partial results must
come " +
619           "from the same row");
{code}
Can you add partialResultsRow and row to message of IOE ?
{code}
5543        if (!NextState.isValidState(state)) {
5544          throw new IOException("Invalid state returned from nextInternal");
{code}
Is it possible to include state in the message of IOE ?

> RegionScannerImpl filters should not be reset if a partial Result is returned
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-13193
>                 URL: https://issues.apache.org/jira/browse/HBASE-13193
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jonathan Lawlor
>            Assignee: Jonathan Lawlor
>         Attachments: HBASE-13193-v1.patch, HBASE-13193-v2.patch
>
>
> In RegionScannerImpl the filters get reset during calls to nextRaw:
> {code}
> public NextState nextRaw(List<Cell> outResults, int batchLimit, long remainingResultSize)
>         throws IOException {
>   ...
>   resetFilters();
>   if (isFilterDoneInternal()) {
>   ...
> }
> {code}
> This creates a problem when returning partial Results because filters should only be
reset in between rows (i.e. after all of the cells for a particular row have been returned).
If a partial Result is returned, there are still cells in the row that have not been evaluated
yet and we should avoid resetting the filter since it will wipe away all state information
for that filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message