hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13139) Clean up missing JAVA_HOME message in bin/hbase-config.sh
Date Tue, 03 Mar 2015 00:32:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344143#comment-14344143
] 

Hadoop QA commented on HBASE-13139:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12701993/0001-HBASE-13139-Clean-up-missing-JAVA_HOME-message-in-bi.patch
  against master branch at commit 74e36f8ddd03cf94c17bdb30ecd81cc5dff4d063.
  ATTACHMENT ID: 12701993

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.
    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM.testSecureMode(TestSecureNNWithQJM.java:159)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13042//console

This message is automatically generated.

> Clean up missing JAVA_HOME message in bin/hbase-config.sh
> ---------------------------------------------------------
>
>                 Key: HBASE-13139
>                 URL: https://issues.apache.org/jira/browse/HBASE-13139
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.0.0, 2.0.0, 0.98.10.1
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Trivial
>         Attachments: 0001-HBASE-13139-Clean-up-missing-JAVA_HOME-message-in-bi.patch,
0001-HBASE-13139-Clean-up-missing-JAVA_HOME-message-in-bi.patch
>
>
> The message needs to be consisten to what the script does:
> Currently we say:
> {code}
> # Now having JAVA_HOME defined is required
> if [ -z "$JAVA_HOME" ]; then
>     cat 1>&2 <<EOF
> +======================================================================+
> |      Error: JAVA_HOME is not set and Java could not be found         |
> +----------------------------------------------------------------------+
> | Please download the latest Sun JDK from the Sun Java web site        |
> |       > http://java.sun.com/javase/downloads/ <                      |
> |                                                                      |
> | HBase requires Java 1.7 or later.                                    |
> | NOTE: This script will find Sun Java whether you install using the   |
> |       binary or the RPM based installer.                             |
> +======================================================================+
> EOF
> {code}
> this should be more like this:
> {code}
> +======================================================================+
> |                    Error: JAVA_HOME is not set                       |
> +----------------------------------------------------------------------+
> | Please download the latest Sun JDK from the Sun Java web site        |
> |       > http://java.sun.com/javase/downloads/ <                      |
> |                                                                      |
> | HBase requires Java 1.7 or later.                                    |
> +======================================================================+
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message