hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13058) Hbase shell command 'scan' for non existent table shows unnecessary info for one unrelated existent table.
Date Fri, 06 Mar 2015 03:01:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349871#comment-14349871
] 

Hadoop QA commented on HBASE-13058:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12702939/HBASE-13058_v2_rebased.patch
  against master branch at commit d58cce1694c22f8f895dceaaf2b2003f69d04ea4.
  ATTACHMENT ID: 12702939

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13108//console

This message is automatically generated.

> Hbase shell command 'scan' for non existent table shows unnecessary info for one unrelated
existent table.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13058
>                 URL: https://issues.apache.org/jira/browse/HBASE-13058
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Abhishek Kumar
>            Assignee: Abhishek Kumar
>            Priority: Trivial
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 0001-HBASE-13058-Error-messages-in-scan-table.patch, 0001-HBASE-13058-shell-unknown-table-message-update.patch,
HBASE-13058-v2.patch, HBASE-13058_v2_rebased.patch
>
>
> When scanning for a non existent table in hbase shell, error message in shell  sometimes(based
on META table content) displays completely unrelated table info , which seems to be unnecessary
and inconsistent with other error messages:
> {noformat}
> hbase(main):016:0> scan 'noTable'
> ROW                                              COLUMN+CELL
> ERROR: Unknown table Table 'noTable' was not found, got: hbase:namespace.!
> ---------------------------------------------------------------------------------------------
> hbase(main):017:0> scan '01_noTable'
> ROW                                              COLUMN+CELL
> ERROR: Unknown table 01_noTable!
> --------------------------------------------------
> {noformat}
> Its happening when doing a META table scan (to locate input table ) and scanner stops
at row of another table (beyond which table can not exist) in ConnectionManager.locateRegionInMeta:
> {noformat}
> private RegionLocations locateRegionInMeta(TableName tableName, byte[] row,
>                    boolean useCache, boolean retry, int replicaId) throws IOException
{
> .................................
> ................................
> // possible we got a region of a different table...
>           if (!regionInfo.getTable().equals(tableName)) {
>             throw new TableNotFoundException(
>                   "Table '" + tableName + "' was not found, got: " +
>                   regionInfo.getTable() + ".");
>           }
> ...............................
> ...............................
> {noformat}
> Here, we can simply put a debug message(if required) and just throw the TableNotFoundException(tableName)
 with only tableName instead of with scanner positioned row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message