hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12931) The existing KeyValues in memstroe are not removed completely after inserting cell into memStore
Date Thu, 05 Mar 2015 15:23:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348859#comment-14348859
] 

Hadoop QA commented on HBASE-12931:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org
  against master branch at commit c15e684bf91fffee4fb43e5a1440154a6db2d3db.
  ATTACHMENT ID: http:

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13102//console

This message is automatically generated.

> The existing KeyValues in memstroe are not removed completely after inserting cell into
memStore 
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12931
>                 URL: https://issues.apache.org/jira/browse/HBASE-12931
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ChiaPing Tsai
>            Priority: Minor
>         Attachments: HBASE-12931
>
>
> If I'm not wrong, the UPSERT method of memStore should remove all existing KeyValues
except the newer version.
> In memStore,
> {code:title=DefaultMemStore.java|borderStyle=solid}
> int versIionsVisible = 0;
> ...
> if (cur.getTypeByte() == KeyValue.Type.Put.getCode() &&
>             cur.getSequenceId() <= readpoint) {
>           if (versionsVisible > 1) {
>             // if we get here we have seen at least one version visible to the oldest
scanner,
>             // which means we can prove that no scanner will see this version
>             // false means there was a change, so give us the size.
>             long delta = heapSizeChange(cur, true);
>             addedSize -= delta;
>             this.size.addAndGet(-delta);
>             it.remove();
>             setOldestEditTimeToNow();
>           } else {
>             versionsVisible++;
>           }
> {code}
> Does "versionsVisible > 1" should be changed to "versionsVisible >= 1" ?
> thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message