hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12586) Task 6 & 7 from HBASE-9117, delete all public HTable constructors and delete ConnectionManager#{delete,get}Connection
Date Tue, 10 Mar 2015 05:41:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354372#comment-14354372

Mikhail Antonov commented on HBASE-12586:

Thinking more about it, I'd probably split this remaining work on API cleanup into several
pieces, which I'd like to discuss here (or is it better to move it to other place? please
excuse me if I'm bringing up points discussed elsewhere..). 

One is this (removing public HTable constructors).

The second one is the general notion of cached/managed connection. Javadoc in ConnectionManager
suggests that connection caching is going away. So shall we remove LRU cache of them from
CM for 2.0? And thinking more long-term..are we going to get rid of notion of managed connections?

The other one is about number of methods to acquire connections. Currently we have ConnectionManager,
which has a bunch of deprecated methods (to be replaced with ConnectionFactory calls) and
also encapsulated HConnectionImplementation (which is directly accessed and constructed from
ConnectionFactory), and we also have HConnectionManager class (the naming would suggest it's
an impl of ConnectionManager, but it's totally unrelated), which is also deprecated. Would
the following make sense as an aggressive, yet meaningful cleanup? :) or may be parts of that
could be accommodated:

 - Take HConnectionImplementation out as a top-level class
 - Remove HConnectionManager
 - Migrate code using ConnectionManager to use ConnectionFactory when possible

> Task 6 & 7 from HBASE-9117,  delete all public HTable constructors and delete ConnectionManager#{delete,get}Connection
> ----------------------------------------------------------------------------------------------------------------------
>                 Key: HBASE-12586
>                 URL: https://issues.apache.org/jira/browse/HBASE-12586
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: Mikhail Antonov
>              Labels: beginner, beginners
>         Attachments: HBASE-12586.patch, HBASE-12586.patch, HBASE-12586.patch, HBASE-12586.patch
> Finish cleanup from HBASE-9117 removing old API.  This issue covers tasks 6 and 7 from
the list here: https://issues.apache.org/jira/browse/HBASE-9117?focusedCommentId=13919716&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13919716
> To be done in master branch only.
> Marked as beginner task.  The idea is straight-forward.  It is just a lot of work going
through all tests converting to use new API.

This message was sent by Atlassian JIRA

View raw message