hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12586) Task 6 & 7 from HBASE-9117, delete all public HTable constructors and delete ConnectionManager#{delete,get}Connection
Date Sat, 07 Mar 2015 03:58:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351378#comment-14351378
] 

Hadoop QA commented on HBASE-12586:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12703205/HBASE-12586.patch
  against master branch at commit 95fc53f1056238e0b5f65df7f3015f2aec3d0a20.
  ATTACHMENT ID: 12703205

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 27 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1931 checkstyle
errors (more than the master's current 1930 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
                  org.apache.hadoop.hbase.master.handler.TestTableDescriptorModification
                  org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
                  org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
                  org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
                  org.apache.hadoop.hbase.regionserver.TestJoinedScanners
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
                  org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
                  org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
                  org.apache.hadoop.hbase.master.TestMaster
                  org.apache.hadoop.hbase.regionserver.TestTags
                  org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
                  org.apache.hadoop.hbase.security.access.TestAccessController
                  org.apache.hadoop.hbase.quotas.TestQuotaAdmin
                  org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.client.TestTimestampsFilter
                  org.apache.hadoop.hbase.TestMetaTableAccessorNoCluster
                  org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
                  org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
                  org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
                  org.apache.hadoop.hbase.security.access.TestAccessController2
                  org.apache.hadoop.hbase.trace.TestHTraceHooks
                  org.apache.hadoop.hbase.master.TestRegionPlacement
                  org.apache.hadoop.hbase.regionserver.TestCompactionState
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs
                  org.apache.hadoop.hbase.fs.TestBlockReorder
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
                  org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter
                  org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.util.TestHBaseFsck
                  org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
                  org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink
                  org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
                  org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
                  org.apache.hadoop.hbase.filter.TestColumnRangeFilter
                  org.apache.hadoop.hbase.mapreduce.TestCopyTable
                  org.apache.hadoop.hbase.util.TestMergeTable
                  org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
                  org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
                  org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
                  org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication
                  org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
                  org.apache.hadoop.hbase.mapred.TestTableInputFormat
                  org.apache.hadoop.hbase.util.TestRegionSplitter
                  org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths
                  org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload
                  org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
                  org.apache.hadoop.hbase.security.access.TestAccessControlFilter
                  org.apache.hadoop.hbase.backup.TestHFileArchiving
                  org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator
                  org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
                  org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicas
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
                  org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormat
                  org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
                  org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.filter.TestScanRowPrefix
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
                  org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
                  org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence
                  org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
                  org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
                  org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack
                  org.apache.hadoop.hbase.security.access.TestNamespaceCommands
                  org.apache.hadoop.hbase.mapreduce.TestCellCounter
                  org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController
                  org.apache.hadoop.hbase.mapreduce.TestWALPlayer
                  org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
                  org.apache.hadoop.hbase.filter.TestFilterWrapper
                  org.apache.hadoop.hbase.master.TestTableStateManager
                  org.apache.hadoop.hbase.TestAcidGuarantees
                  org.apache.hadoop.hbase.TestHBaseTestingUtility
                  org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
                  org.apache.hadoop.hbase.TestFullLogReconstruction
                  org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
                  org.apache.hadoop.hbase.TestInfoServers
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack
                  org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting
                  org.apache.hadoop.hbase.replication.TestReplicationWithTags
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
                  org.apache.hadoop.hbase.regionserver.TestHRegion
                  org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
                  org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.mapreduce.TestRowCounter
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
                  org.apache.hadoop.hbase.replication.TestReplicationEndpoint
                  org.apache.hadoop.hbase.master.TestTableLockManager
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient
                  org.apache.hadoop.hbase.security.access.TestScanEarlyTermination
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
                  org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat
                  org.apache.hadoop.hbase.master.TestMasterTransitions
                  org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
                  org.apache.hadoop.hbase.replication.TestReplicationSmallTests
                  org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
                  org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups
                  org.apache.hadoop.hbase.TestMetaTableAccessor
                  org.apache.hadoop.hbase.master.TestAssignmentListener
                  org.apache.hadoop.hbase.quotas.TestQuotaThrottle
                  org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
                  org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
                  org.apache.hadoop.hbase.regionserver.TestSCVFWithMiniCluster
                  org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
                  org.apache.hadoop.hbase.security.access.TestTablePermissions
                  org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
                  org.apache.hadoop.hbase.replication.TestMasterReplication
                  org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
                  org.apache.hadoop.hbase.master.handler.TestEnableTableHandler
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.wal.TestWALFiltering
                  org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s): 	at org.apache.hadoop.hbase.ResourceCheckerJUnitListener.testStarted(ResourceCheckerJUnitListener.java:178)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testSSHWaitForServerToAssignRegion(TestAssignmentManagerOnCluster.java:855)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRacingWithSSH(TestAssignmentManagerOnCluster.java:839)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testCloseHang(TestAssignmentManagerOnCluster.java:693)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testMoveRegionOfDeletedTable(TestAssignmentManagerOnCluster.java:400)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignDisabledRegionBySSH(TestAssignmentManagerOnCluster.java:1088)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOpenFailed(TestAssignmentManagerOnCluster.java:561)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOpenFailedUnrecoverable(TestAssignmentManagerOnCluster.java:610)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testCloseFailed(TestAssignmentManagerOnCluster.java:520)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRegion(TestAssignmentManagerOnCluster.java:206)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRegionOnRestartedServer(TestAssignmentManagerOnCluster.java:263)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testMoveRegion(TestAssignmentManagerOnCluster.java:354)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testReportRegionStateTransition(TestAssignmentManagerOnCluster.java:1123)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignOfflinedRegionBySSH(TestAssignmentManagerOnCluster.java:1011)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignWhileClosing(TestAssignmentManagerOnCluster.java:474)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOfflineRegion(TestAssignmentManagerOnCluster.java:304)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testSSHWaitForServerToAssignRegion(TestAssignmentManagerOnCluster.java:889)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRacingWithSSH(TestAssignmentManagerOnCluster.java:839)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testCloseHang(TestAssignmentManagerOnCluster.java:693)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testMoveRegionOfDeletedTable(TestAssignmentManagerOnCluster.java:400)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignDisabledRegionBySSH(TestAssignmentManagerOnCluster.java:1088)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOpenFailed(TestAssignmentManagerOnCluster.java:561)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOpenFailedUnrecoverable(TestAssignmentManagerOnCluster.java:610)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testCloseFailed(TestAssignmentManagerOnCluster.java:520)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRegion(TestAssignmentManagerOnCluster.java:206)
	at org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignRegionOnRestartedServer(TestAssignmentManagerOnCluster.java:263)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13128//console

This message is automatically generated.

> Task 6 & 7 from HBASE-9117,  delete all public HTable constructors and delete ConnectionManager#{delete,get}Connection
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12586
>                 URL: https://issues.apache.org/jira/browse/HBASE-12586
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: Mikhail Antonov
>              Labels: beginner, beginners
>         Attachments: HBASE-12586.patch, HBASE-12586.patch
>
>
> Finish cleanup from HBASE-9117 removing old API.  This issue covers tasks 6 and 7 from
the list here: https://issues.apache.org/jira/browse/HBASE-9117?focusedCommentId=13919716&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13919716
> To be done in master branch only.
> Marked as beginner task.  The idea is straight-forward.  It is just a lot of work going
through all tests converting to use new API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message