hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12413) Mismatch in the equals and hashcode methods of KeyValue
Date Fri, 27 Mar 2015 02:33:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383247#comment-14383247
] 

Ted Yu commented on HBASE-12413:
--------------------------------

lgtm
{code}
1068	   * In line with {@link #equals(Object)}, only compares the key portion,
1069	   * not the value.
{code}
Looks like the verb 'compares' is not accurate: we're calculating hash code, right ?

> Mismatch in the equals and hashcode methods of KeyValue
> -------------------------------------------------------
>
>                 Key: HBASE-12413
>                 URL: https://issues.apache.org/jira/browse/HBASE-12413
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>            Priority: Minor
>         Attachments: HBASE-12413-V2.diff, HBASE-12413.diff, HBASE-12413.v3.patch
>
>
> In the equals method of KeyValue only row key is compared, and in the hashcode method
all bacing bytes are calculated. This breaks the Java rule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message