Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 20 Feb 2015 14:19:13 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12776401.1424425782000.94980.1424441953104@Atlassian.JIRA>
In-Reply-To: <JIRA.12776401.1424425782000@Atlassian.JIRA>
References: <JIRA.12776401.1424425782000@Atlassian.JIRA>
 <JIRA.12776401.1424425782217@arcas>
Subject: [jira] [Commented] (HBASE-13080) Hbase shell message containing
 extra quote at the end of error message.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328958#comment-14328958 ] 

Matteo Bertozzi commented on HBASE-13080:
-----------------------------------------

looks good, but looks like there is another one
{noformat}
$ git grep "\.'\""
hbase-shell/src/main/ruby/hbase/admin.rb:      raise ArgumentError, "Table #{table_name} does not exist.'" unless exists?(table_name)
hbase-shell/src/main/ruby/hbase/admin.rb:      raise ArgumentError, "Table #{table_name} is enabled. Disable it first.'" if enabled?(table_name)
hbase-shell/src/main/ruby/hbase/admin.rb:      raise ArgumentError, "Table #{table_name} is not enabled. Enable it first.'" unless enabled?(table_name)
{noformat}

> Hbase shell message containing extra quote at the end of error message.
> -----------------------------------------------------------------------
>
>                 Key: HBASE-13080
>                 URL: https://issues.apache.org/jira/browse/HBASE-13080
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Abhishek Kumar
>            Priority: Trivial
>         Attachments: 0001-HBASE-13080-remove-extra-quote-typo.patch
>
>
> {noformat}
> hbase(main):001:0> drop 't2'
> ERROR: Table t2 is enabled. Disable it first.'
> ---------------------------
> hbase(main):001:0> disable 'noTable'
> ERROR: Table csadfsdfsdf does not exist.'
> {noformat}
> extra quote at the end odf error message seems to be a typo, can be removed from below two methods in admin.rb :
> {noformat}
>  # Throw exception if table doesn't exist
>     def tableExists(table_name)
>       raise ArgumentError, "Table #{table_name} does not exist.'" unless    exists?(table_name)
>     end
> ========================
> # Drops a table
>     def drop(table_name)
>       tableExists(table_name)
>       raise ArgumentError, "Table #{table_name} is enabled. Disable it first.'" if enabled?(table_name)
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)