Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1973B178D2 for ; Tue, 17 Feb 2015 06:54:47 +0000 (UTC) Received: (qmail 58100 invoked by uid 500); 17 Feb 2015 06:54:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 57998 invoked by uid 500); 17 Feb 2015 06:54:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57795 invoked by uid 99); 17 Feb 2015 06:54:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 06:54:11 +0000 Date: Tue, 17 Feb 2015 06:54:11 +0000 (UTC) From: "Vikas Vishwakarma (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HBASE-13056) Refactor table.jsp code to remove repeated code and make it easier to add new checks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Vishwakarma reassigned HBASE-13056: ----------------------------------------- Assignee: Vikas Vishwakarma > Refactor table.jsp code to remove repeated code and make it easier to add new checks > ------------------------------------------------------------------------------------ > > Key: HBASE-13056 > URL: https://issues.apache.org/jira/browse/HBASE-13056 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Vikas Vishwakarma > Assignee: Vikas Vishwakarma > Fix For: 2.0.0 > > > While trying to fix HBASE-13001, I realized that there is lot of html code repetition in table.jsp which is making addition of new checks slightly difficult in the sense I will have to: > 1. Add the check at multiple places in the code > Or > 2. Repeat the html code again for the new check > So I am proposing to re-factor table.jsp code such that the common html header/body is loaded without any condition check and then we generate the condition specific html code > snapshot.jsp follows the same format as explained below: > {noformat} > Current implementation: > ==================== > if( x ) { > title_x > common_html_header > common_html_body > x_specific_html_body > } else { > title_y > common_html_header > common_html_body > y_specific_html_body > } > New Implementation: > ================== > if( x ) { > title_x > } else { > title_y > } > common_html_header > common_html_body > if( x ) { > x_specific_html_body > } else { > y_specific_html_body > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)