Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA07817DA3 for ; Thu, 12 Feb 2015 06:53:12 +0000 (UTC) Received: (qmail 38007 invoked by uid 500); 12 Feb 2015 06:53:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 37964 invoked by uid 500); 12 Feb 2015 06:53:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 37734 invoked by uid 99); 12 Feb 2015 06:53:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Feb 2015 06:53:12 +0000 Date: Thu, 12 Feb 2015 06:53:12 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13007) Fix the test timeouts being caused by ChoreService MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317712#comment-14317712 ] Hudson commented on HBASE-13007: -------------------------------- FAILURE: Integrated in HBase-1.1 #170 (See [https://builds.apache.org/job/HBase-1.1/170/]) HBASE-13007 Fix the test timeouts being caused by ChoreService (Jonathan Lawlor); ADDENDUM (stack: rev aca9aacfb41a4027c6548c240611cf80a29c8ec3) * hbase-common/src/test/java/org/apache/hadoop/hbase/TestChoreService.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java > Fix the test timeouts being caused by ChoreService > --------------------------------------------------- > > Key: HBASE-13007 > URL: https://issues.apache.org/jira/browse/HBASE-13007 > Project: HBase > Issue Type: Bug > Reporter: Jonathan Lawlor > Assignee: Jonathan Lawlor > Fix For: 2.0.0, 1.1.0 > > Attachments: HBASE-13007-v1.patch, HBASE-13007-v2.patch, HBASE-13007-v2.patch, HBASE-13007-v2.patch > > > TestChoreService has been seen timing out in recent builds and the timeouts seem to be rooted in how the ChoreService cancels its chores when being shutdown. The issue is that during shutdown, the ChoreService calls synchronized methods on the ScheduledChore which could cause indefinite blocking if the scheduled chore is hanging in a synchronized method. We should instead call the appropriate cancel method within the ChoreService and add logic into ScheduledChores that allows them to realize when they have been cancelled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)