Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC82817D0A for ; Thu, 26 Feb 2015 16:51:05 +0000 (UTC) Received: (qmail 10945 invoked by uid 500); 26 Feb 2015 16:51:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10904 invoked by uid 500); 26 Feb 2015 16:51:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10891 invoked by uid 99); 26 Feb 2015 16:51:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 16:51:05 +0000 Date: Thu, 26 Feb 2015 16:51:05 +0000 (UTC) From: "Sameet Agarwal (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-12924) HRegionServer#MovedRegionsCleaner Chore does not start MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameet Agarwal updated HBASE-12924: ----------------------------------- Attachment: first-task.patch The patch adds the MovedRegionsCleaner chore to the background chores. Also added a unit test to test this. > HRegionServer#MovedRegionsCleaner Chore does not start > ------------------------------------------------------ > > Key: HBASE-12924 > URL: https://issues.apache.org/jira/browse/HBASE-12924 > Project: HBase > Issue Type: Bug > Reporter: Jonathan Lawlor > Priority: Minor > Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11 > > Attachments: first-task.patch > > > This issue is very similar to the one described in HBASE-11354. The method createAndStart in MovedRegionsCleaner creates an instance of the chore but never starts the underlying thread: > {code} > static MovedRegionsCleaner createAndStart(HRegionServer rs){ > Stoppable stoppable = new Stoppable() { > private volatile boolean isStopped = false; > @Override public void stop(String why) { isStopped = true;} > @Override public boolean isStopped() {return isStopped;} > }; > return new MovedRegionsCleaner(rs, stoppable); > } > {code} > Nobody has noticed this issue so far so the Chore may not be that important -- This message was sent by Atlassian JIRA (v6.3.4#6332)