hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13097) Use same EventLoopGroup for different AsyncRpcClients if possible
Date Sat, 28 Feb 2015 03:02:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341269#comment-14341269
] 

Hadoop QA commented on HBASE-13097:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12701509/HBASE-13097-addendum.patch
  against master branch at commit ec877959d7611ed8edfb15d67f5a662080c2e6da.
  ATTACHMENT ID: 12701509

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.
    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13008//console

This message is automatically generated.

> Use same EventLoopGroup for different AsyncRpcClients if possible
> -----------------------------------------------------------------
>
>                 Key: HBASE-13097
>                 URL: https://issues.apache.org/jira/browse/HBASE-13097
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC, test
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: zhangduo
>            Assignee: zhangduo
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13097-addendum.patch, HBASE-13097.patch, HBASE-13097_1.patch,
HBASE-13097_2.patch
>
>
> In some unit tests(such as TestAcidGuarantees) we create multiple Connection instance.
If we use AsyncRpcClient, then there will be multiple netty Bootstrap and every Bootstrap
has its own PooledByteBufAllocator.
> I haven't read the code clearly but it uses some threadlocal technics and jmap shows
io.netty.buffer.PoolThreadCache$MemoryRegionCache$Entry is the biggest things on Heap.
> See https://builds.apache.org/job/HBase-TRUNK/6168/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.TestAcidGuarantees-output.txt
> {noformat}
> 2015-02-24 23:50:29,704 WARN  [JvmPauseMonitor] util.JvmPauseMonitor$Monitor(167): Detected
pause in JVM or host machine (eg GC): pause of approximately 20133ms
> GC pool 'PS MarkSweep' had collection(s): count=15 time=55525ms
> {noformat}
> Update: We use a singleton PooledByteBufAllocator so the reason should be too many threads.
So we will work on reduce the connections and rpclients in unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message