hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13056) Refactor table.jsp code to remove repeated code and make it easier to add new checks
Date Tue, 17 Feb 2015 09:22:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323984#comment-14323984
] 

Hadoop QA commented on HBASE-13056:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12699217/HBASE-13056.patch
  against master branch at commit bfc2bc7fa2101eafa8fd63a86223e1a15f74d434.
  ATTACHMENT ID: 12699217

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.
    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestDistributedLogSplitting

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testMasterStartsUpWithLogReplayWork(TestDistributedLogSplitting.java:524)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12875//console

This message is automatically generated.

> Refactor table.jsp code to remove repeated code and make it easier to add new checks
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-13056
>                 URL: https://issues.apache.org/jira/browse/HBASE-13056
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Vikas Vishwakarma
>            Assignee: Vikas Vishwakarma
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13056.patch
>
>
> While trying to fix HBASE-13001, I realized that there is lot of html code repetition
in table.jsp which is making addition of new checks slightly difficult in the sense I will
have to:
> 1. Add the check at multiple places in the code
> Or 
> 2. Repeat the html code again for the new check 
> So I am proposing to re-factor table.jsp code such that the common html header/body is
loaded without any condition check and then we generate the condition specific html code 
> snapshot.jsp follows the same format as explained below:
> {noformat}
> Current implementation:
> ====================
> if( x ) {
>   title_x
>   common_html_header
>   common_html_body
>   x_specific_html_body
> } else {
>   title_y
>   common_html_header
>   common_html_body
>   y_specific_html_body
> }
> New Implementation:
> ==================
> if( x ) {
>   title_x
> } else {
>   title_y
> }
> common_html_header
> common_html_body
> if( x ) {
>   x_specific_html_body
> } else {
>   y_specific_html_body
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message