hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Vishwakarma (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-13056) Refactor table.jsp code to remove repeated code and make it easier to add new checks
Date Tue, 17 Feb 2015 06:54:11 GMT
Vikas Vishwakarma created HBASE-13056:
-----------------------------------------

             Summary: Refactor table.jsp code to remove repeated code and make it easier to
add new checks
                 Key: HBASE-13056
                 URL: https://issues.apache.org/jira/browse/HBASE-13056
             Project: HBase
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Vikas Vishwakarma
             Fix For: 2.0.0


While trying to fix HBASE-13001, I realized that there is lot of html code repetition in table.jsp
which is making addition of new checks slightly difficult in the sense I will have to:
1. Add the check at multiple places in the code
Or 
2. Repeat the html code again for the new check 

So I am proposing to re-factor table.jsp code such that the common html header/body is loaded
without any condition check and then we generate the condition specific html code 

snapshot.jsp follows the same format as explained below:

{noformat}
Current implementation:
====================

if( x ) {

  title_x
  common_html_header
  common_html_body
  x_specific_html_body

} else {

  title_y
  common_html_header
  common_html_body
  y_specific_html_body

}

New Implementation:
==================
if( x ) {

  title_x

} else {

  title_y

}
common_html_header
common_html_body

if( x ) {

  x_specific_html_body

} else {

  y_specific_html_body

}
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message