hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13050) Hbase shell create_namespace command throws ArrayIndexOutOfBoundException for (invalid) empty text input.
Date Tue, 17 Feb 2015 08:50:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323943#comment-14323943
] 

Abhishek Kumar commented on HBASE-13050:
----------------------------------------

Updated patch attached with empty Namespace test case (TestTableName.testEmptyNamespaceName)
, pls take a look at it.

> Hbase shell create_namespace command throws ArrayIndexOutOfBoundException for (invalid)
empty text input.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13050
>                 URL: https://issues.apache.org/jira/browse/HBASE-13050
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Abhishek Kumar
>            Priority: Trivial
>         Attachments: 0001-HBASE-13050-Empty-Namespace-name-validation.patch
>
>
> {noformat}
> hbase(main):008:0> create_namespace ''
> ERROR: java.io.IOException: 0
>         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2072)
>         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:107)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
>         at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
>         at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:222)
>         at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:205)
> {noformat}
> TableName.isLegalNamespaceName tries to access namespaceName[offset] in case of empty
text input and also this check for 'offset==length' in this method seems to be unnecessary
and an empty  input validation check can be put in the beginning of this method instead:
> {noformat}
>  public static void isLegalNamespaceName(byte[] namespaceName, int offset, int length)
{
> // can add empty check in the beginning 
>   if(length == 0) {
>       throw new IllegalArgumentException("Namespace name must not be empty");
>     }
> // end
>     for (int i = offset; i < length; i++) {
>       if (Character.isLetterOrDigit(namespaceName[i])|| namespaceName[i] == '_') {
>         continue;
>       }
>       throw new IllegalArgumentException("Illegal character <" + namespaceName[i]
+
>         "> at " + i + ". Namespaces can only contain " +
>         "'alphanumeric characters': i.e. [a-zA-Z_0-9]: " + Bytes.toString(namespaceName,
>           offset, length));
>     }
>  //  can remove below check
>    if(offset == length)
>       throw new IllegalArgumentException("Illegal character <" + _namespaceName[offset]
_+
>           "> at " + offset + ". Namespaces can only contain " +
>           "'alphanumeric characters': i.e. [a-zA-Z_0-9]: " + Bytes.toString(namespaceName,
>             offset, length));
>  // 
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message