hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13044) Configuration option for disabling coprocessor loading
Date Sat, 14 Feb 2015 07:10:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321280#comment-14321280
] 

Sean Busbey commented on HBASE-13044:
-------------------------------------

Please print an INFO log message for wether or not each of the coprocessor types are loading.

Is it worth adding a test where both are expressly enabled? I guess in case we change defaults?

{quote}
+  private static AtomicBoolean systemCoprocessorLoaded = new AtomicBoolean();
+  private static AtomicBoolean tableCoprocessorLoaded = new AtomicBoolean();
{quote}

should be final.

{quote}
nit: In testTableLoadingDisabled, do we need "conf.setBoolean(CoprocessorHost.COPROCESSORS_ENABLED_CONF_KEY,
true);" ?
{quote}

Because the default might not be to have things enabled.

{quote}
Also, I'm curious about why "AtomicBoolean" is used for *loaded variables instead of boolean?
{quote}

because the variables are being modified from multiple threads. we could also use {{volatile}}
instead of AtomicBoolean, but most people find that more confusing.

> Configuration option for disabling coprocessor loading
> ------------------------------------------------------
>
>                 Key: HBASE-13044
>                 URL: https://issues.apache.org/jira/browse/HBASE-13044
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 2.0.0, 1.0.1, 0.98.11, 1.1.1
>
>         Attachments: HBASE-13044.patch
>
>
> Some users would like complete assurance coprocessors cannot be loaded. Add a configuration
option that prevents coprocessors from ever being loaded by ignoring any load directives found
in the site file or table metadata. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message