hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13030) [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc., addColumn
Date Fri, 13 Feb 2015 00:47:16 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-13030:
--------------------------
    Attachment: 13030v5.txt

@enis Thanks.

Here is your patch with a minor diff:

 73
 74 -  // If application wants to collect scan metrics, it needs to
 75 -  // call scan.setAttribute(SCAN_ATTRIBUTES_ENABLE, Bytes.toBytes(Boolean.TRUE))
 76 +  /**
 77 +   * @deprecated since 1.0.0. Use {@link #setMetricsEnabled(boolean)}
 78 +   */
 79 +  @Deprecated
 80    static public final String SCAN_ATTRIBUTES_METRICS_ENABLE = "scan.attributes.metrics.enable";


Am being more conservative than you given we are late in the game leaving this as public deprecated
rather than made private (fix javadoc issue too).

> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, Delete, etc.,
addColumn
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13030
>                 URL: https://issues.apache.org/jira/browse/HBASE-13030
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 1.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>
>         Attachments: 13030.txt, 13030v2.txt, 13030v3.txt, 13030v5.txt, hbase-13030-scanmetrics.patch
>
>
> These are some of the items raised by [~larsgeorge] looking at our API for first time
in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it is IA.private
and to get at it from Scan context, you need to use private ProtobufUtils. This seems like
useful advanced user utility that should not be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly but didn't
want to do anything more adventurous this late in the game).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message